Add ui tests for notifications

[asnaith]

closes #2018

Adds tests for

• card expiring soon notification
• open crypto invoice notification

[render]

Your Render PR Server URL is https://chainsafe-components-stage-pr-2019.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8onshvd17c0hukm4ha0.

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-2019.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8onsivd17c0hukm4heg.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-2019.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8onsjvd17c0hukm4hs0.

[asnaith]

I realized that by introducing the test for the crypto invoice notification I have affected another test in the subscription plan spec related to crypto payments (it's not expecting an unpaid invoice row to be there at the beginning of the test).

I might have to see if there's a way to use separate sessions for each test to prevent a conflict as there's not a way to clear down that state afaik.

[Tbaut]

I pushed commit to add a flag to generate a random session id, and force a new session.

[Tbaut]

Looks good, just left a small comment

[Tbaut]

I would use a boolean here isCardExpired instead
If you want to make this easier to read, then instead of having 2 params, you can change this for object 1 param, with the type {plan: "pro"|"max", isCardExpired: boolean}. Then when you call this function, the params are easy to read, rather than func("pro", true), it'd be func({plan: "pro", isCardExpired: true})

edit: Maybe what you wanted to test is the fact that it's expiring this month, the name would change, but not the idea.

[asnaith]

@Tbaut thanks for the explanation and letting me know about this approach, I've updated this now 🙏.

[Tbaut]

It failed with the following, but it passed locally :(

|       1) can initiate and return to a crypto payment flow within 60 minutes
| 
| 
|   9 passing (3m)
|   1 failing
| 
|   1) Subscription Plan
|        desktop
|          can initiate and return to a crypto payment flow within 60 minutes:
|      CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is `disabled`:

edit: This looks like an api issue. The returnToFreePlan flag fails.

[asnaith]

edit: This looks like an api issue. The returnToFreePlan flag fails.

@Tbaut Unfortunately I got stuck on this and was unable to resolve it but I'm fairly confident it's not an API issue (well, it seems related to the API but not caused by the API). I've tried many things but am not fully understanding the underlying issue.

I can replicate the issue outside of CI though. Currently, with the two tests marked as it.only, the first time that you run them both they will pass as they both are using new sessions. Afterwards, if you then click the "run all tests" button to do a second run...

The test that is restoring the session will fail on the resetToFreePlan every time, whilst the other test continues to run and pass as it is always using a new session. If you clear the sessions everything works again too (guess that's obvious 😄). So it seems like something weird is going on when using apiTestHelper after a session restore (maybe with the token refresh?).

I'll continue to look at it tomorrow with a fresh brain but if you have any ideas please let me know (and thanks for your help so far with this!).

[Tbaut]

Hey Andrew, from the suite of calls perspective, there's 100% something weird with the api. This should be tackled in this PR https://github.com/ChainSafe/files-api/pull/2082 I couldn't test with the api preview unfortunately so we'll have to wait until it's merged.

The problem is with the "return to free subscription" helper, that is failing for no apparent reason.

[Tbaut]

ok I have some news. The "back to free plan" logic does not work if the user that we have is currently having a subscription awaiting payment, which is the case when we have a crypto test right before. There is no way we can go around this api limitation.

So the solution is to use my "newSesion" flag, every time we do something with crypto.

[asnaith]

@Tbaut as mentioned on slack, the issues described above are now resolved by the latest api release on stage :)