Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI layout adjustments and sticky bulk actions #2074

Merged
merged 5 commits into from
Apr 10, 2022
Merged

UI layout adjustments and sticky bulk actions #2074

merged 5 commits into from
Apr 10, 2022

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Apr 5, 2022 •
edited
Loading

closes #2052

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

Storage

  • Change applied to both files-ui and storage-ui

@render
Copy link

render bot commented Apr 5, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2074.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9699rj19n08vj87gepg.

@render
Copy link

render bot commented Apr 5, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2074.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9699sj19n08vj87geu0.

@render
Copy link

render bot commented Apr 5, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2074.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9699tj19n08vj87gffg.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Apr 5, 2022
@asnaith
Copy link
Member

asnaith commented Apr 6, 2022 •
edited
Loading

Nice improvement, looking good in Chrome and Safari.

I know this is still a draft but I noticed a small quirk on Firefox where the container is no longer dimmed when the upload modal is in view:

Screen Shot 2022-04-05 at 8 54 20 PM

@tanmoyAtb tanmoyAtb marked this pull request as ready for review April 6, 2022 17:28
@tanmoyAtb tanmoyAtb requested review from Tbaut, FSM1 and asnaith April 6, 2022 17:28
@tanmoyAtb
Copy link
Contributor Author

Nice improvement, looking good in Chrome and Safari.

I know this is still a draft but I noticed a small quirk on Firefox where the container is no longer dimmed when the upload modal is in view:

Screen Shot 2022-04-05 at 8 54 20 PM

Great catch @asnaith , I surely would have missed this one.

@tanmoyAtb
Copy link
Contributor Author

tanmoyAtb commented Apr 6, 2022 •
edited
Loading

The overall changes has some effect on most of the page layouts, in storage and files.
Here's a preview of the sticky bulk actions.

Screen.Recording.2022-04-06.at.11.31.03.PM.mov

Tbaut
Tbaut approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super slick!

asnaith
asnaith approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great in firefox and for storage too

@tanmoyAtb tanmoyAtb merged commit a1e41ae into dev Apr 10, 2022
@tanmoyAtb tanmoyAtb deleted the feat/bulk-actions-appearance-2052 branch April 10, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@asnaith asnaith asnaith approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With a long list of files on desktop the bulk actions should be sticky to the top of the screen
3 participants
@tanmoyAtb @asnaith @Tbaut