-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Files] Change language test #2192
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2192.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal0qjehb05ha9ifqo70. |
Your Render PR Server URL is https://files-ui-stage-pr-2192.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal0qkmhb05ha9ifqoc0. |
Your Render PR Server URL is https://storage-ui-stage-pr-2192.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal0qluhb05ha9ifqotg. |
Some subscription tests failed but not because of this PR, I already reported to API team |
Thanks for adding this Juan 👍 I know we usually don't check element text values in tests but for a change language test I think it makes sense and what you have used seems very unlikely to change so I'm ok with it for this purpose. I pushed a few additional commits to update identifiers, simplify assertions, and increased the test reliability by waiting on the last api response (after language select + page refresh) before the assertions. The latter helped avoid "detached from DOM" errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!
Merging since this has nothing to do with the failing tests that is being taken care of |
Thanks for the updates! now I know that I don't need the exact element to get the text, I can get it finding the parent element (I think in Selenium is not like that, because of that I didn't know that Cypress can do it). And using the intercept for wait to finish is awesome too, Didn't think about that |
closes #2171