Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IPFS MFS filesystem creation #2239

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Disable IPFS MFS filesystem creation #2239

merged 6 commits into from
Aug 8, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Aug 4, 2022

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Aug 4, 2022

@FSM1 FSM1 requested a review from tanmoyAtb August 4, 2022 19:02
@render
Copy link

render bot commented Aug 4, 2022

@FSM1 FSM1 requested review from Tbaut and tanmoyAtb and removed request for tanmoyAtb August 4, 2022 19:02
@render
Copy link

render bot commented Aug 4, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 4, 2022
@juans-chainsafe
Copy link
Contributor

@FSM1 Hi! what need to be tested here? do we have a ticket for this with more information?

@FSM1
Copy link
Contributor Author

FSM1 commented Aug 4, 2022

@FSM1 Hi! what need to be tested here? do we have a ticket for this with more information?

Unfortunately there is not a ticket for this change. Due to the performance issues with the IPFS (MFS) filesystem, we have taken a decision to disable this bucket type from creation. I see there are some storage tests failing, which I will go through and make sure that none of the tests depend on this file-system type.

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the purpose at hand, looks good !

@juans-chainsafe
Copy link
Contributor

juans-chainsafe commented Aug 5, 2022

@FSM1 got it! I checked the UI and is ok, buuut I saw that you only commented one IPFS test, but we have a lot more, the thing on the others, is that they create an IPFS buckets using the API, so they are able to create the bucket and the tests passed. All of this in bucket-management.cy.ts I can comment those test as well if you want, but again, they are not failing because they use the API to create the ipfs bucket

@FSM1
Copy link
Contributor Author

FSM1 commented Aug 8, 2022

others, is that they create an IPFS buckets using the API, so they are able to create the bucket and the tests passed. All of this in bucket-management.cy.ts I can comment those test as well if you want, but again, they are not failing because they use the API to create the ipfs bucket

Im happy to have all those tests commented out for now.

@juans-chainsafe
Copy link
Contributor

others, is that they create an IPFS buckets using the API, so they are able to create the bucket and the tests passed. All of this in bucket-management.cy.ts I can comment those test as well if you want, but again, they are not failing because they use the API to create the ipfs bucket

Im happy to have all those tests commented out for now.

Done! tests related to IPFS were commented

@FSM1 FSM1 merged commit bad9a03 into dev Aug 8, 2022
@FSM1 FSM1 deleted the mnt/disable-mfs-filesystem branch August 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants