-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable IPFS MFS filesystem creation #2239
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2239.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbm1fmfho1koe5a4pgj0. |
Your Render PR Server URL is https://files-ui-stage-pr-2239.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbm1fnnho1koe5a4pgng. |
Your Render PR Server URL is https://storage-ui-stage-pr-2239.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbm1fovho1koe5a4ph90. |
@FSM1 Hi! what need to be tested here? do we have a ticket for this with more information? |
Unfortunately there is not a ticket for this change. Due to the performance issues with the IPFS (MFS) filesystem, we have taken a decision to disable this bucket type from creation. I see there are some storage tests failing, which I will go through and make sure that none of the tests depend on this file-system type. |
…Safe/ui-monorepo into mnt/disable-mfs-filesystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the purpose at hand, looks good !
@FSM1 got it! I checked the UI and is ok, buuut I saw that you only commented one IPFS test, but we have a lot more, the thing on the others, is that they create an IPFS buckets using the API, so they are able to create the bucket and the tests passed. All of this in bucket-management.cy.ts I can comment those test as well if you want, but again, they are not failing because they use the API to create the ipfs bucket |
Im happy to have all those tests commented out for now. |
Done! tests related to IPFS were commented |
Submission checklist:
Layout
Theme