Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update gradle to v8.8 #410

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore(deps): update gradle to v8.8 #410

merged 1 commit into from
Jun 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 1, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
gradle (source) minor 8.7 -> 8.8

Release Notes

gradle/gradle (gradle)

v8.8: 8.8

Compare Source

The Gradle team is excited to announce Gradle 8.8.

Read the Release Notes

We would like to thank the following community members for their contributions to this release of Gradle:
Björn Kautler,
Denes Daniel,
Fabian Windheuser,
Hélio Fernandes Sebastião,
Jay Wei,
jhrom,
jwp345,
Jörgen Andersson,
Kirill Gavrilov,
MajesticMagikarpKing,
Maksim Lazeba,
Philip Wedemann,
Robert Elliot,
Róbert Papp,
Stefan M.,
Tibor Vyletel,
Tony Robalik,
Valentin Kulesh,
Yanming Zhou,
김용후

Upgrade instructions

Switch your build to use Gradle 8.8 by updating your wrapper:

./gradlew wrapper --gradle-version=8.8

See the Gradle 8.x upgrade guide to learn about deprecations, breaking changes and other considerations when upgrading.

For Java, Groovy, Kotlin and Android compatibility, see the full compatibility notes.

Reporting problems

If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines.
If you're not sure you're encountering a bug, please use the forum.

We hope you will build happiness with Gradle, and we look forward to your feedback via Twitter or on GitHub.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependencies This involves updating, adding or removing a dependency label Jun 1, 2024
@joshuasing
Copy link
Member

It looks like the warnings are caused by shadowjar: GradleUp/shadow#876

@joshuasing
Copy link
Member

joshuasing commented Jun 2, 2024

I have set Gradle warning mode to all (docs) so that we can merge this.
Once shadowjar merges and releases GradleUp/shadow#876, warning mode should be set back to fail.

@LooFifteen
Copy link
Member

We should probably hold off this merge until shadow is updated, I don't think it's worth turning errors into warnings just to wait for a single dependency.

@joshuasing joshuasing marked this pull request as draft June 2, 2024 15:00
@joshuasing joshuasing added the blocked: external This is blocked by something external label Jun 2, 2024
@joshuasing
Copy link
Member

We should probably hold off this merge until shadow is updated, I don't think it's worth turning errors into warnings just to wait for a single dependency.

Agreed. I have reverted my commit, we'll wait until shadowjar updates.

joshuasing added a commit that referenced this pull request Jun 17, 2024
The Gradle shadow plugin by johnrengelman is currently unmaintained, and
does not currently support the latest versions of Gradle.

There have been discussions regarding the future of the plugin, however
nothing has been acted upon currently: GradleUp/shadow#908

This fork appears to be the most supported and best maintained fork, and
has been suggested as the replacement for the original shadow plugin.

Fixes #414
Related to #410
@joshuasing joshuasing marked this pull request as ready for review June 17, 2024 09:44
@joshuasing
Copy link
Member

Waiting for #415

Copy link
Member

@LooFifteen LooFifteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joshuasing added a commit that referenced this pull request Jun 18, 2024
The Gradle shadow plugin by johnrengelman is currently unmaintained, and
does not currently support the latest versions of Gradle.

There have been discussions regarding the future of the plugin, however
nothing has been acted upon currently: GradleUp/shadow#908

This fork appears to be the most supported and best maintained fork, and
has been suggested as the replacement for the original shadow plugin.

Fixes #414
Related to #410
@joshuasing joshuasing merged commit 143715d into main Jun 19, 2024
4 checks passed
@joshuasing joshuasing deleted the renovate/gradle-8.x branch June 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: external This is blocked by something external type: dependencies This involves updating, adding or removing a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants