Merge branch 'master' of https://github.com/sumlin/Java-OCA-OCPP

ChargeTimeEU · Apr 19, 2018 · 3e7e923 · 3e7e923
2 parents 1d58fdb + 331f747
commit 3e7e923
Show file tree

Hide file tree

Showing 10 changed files with 84 additions and 9 deletions.
diff --git a/...u/chargetime/ocpp/ConfirmatinHandler.java → .../chargetime/ocpp/ConfirmationHandler.java b/...u/chargetime/ocpp/ConfirmatinHandler.java → .../chargetime/ocpp/ConfirmationHandler.java
diff --git a/ocpp-common/src/main/java/eu/chargetime/ocpp/utilities/SugarUtil.java b/ocpp-common/src/main/java/eu/chargetime/ocpp/utilities/SugarUtil.java
@@ -5,6 +5,7 @@
     MIT License
 
     Copyright (C) 2016-2018 Thomas Volden <[email protected]>
+    Copyright (C) 2018 Mikhail Kladkevich <[email protected]>
 
     Permission is hereby granted, free of charge, to any person obtaining a copy
     of this software and associated documentation files (the "Software"), to deal

diff --git a/...6-test/src/test/groovy/eu/chargetime/ocpp/test/reservation/json/JSONReserveNowSpec.groovy b/...6-test/src/test/groovy/eu/chargetime/ocpp/test/reservation/json/JSONReserveNowSpec.groovy
@@ -61,7 +61,7 @@ class JSONReserveNowSpec extends Specification {
         }
 
         when:
-        centralSystem.sendReserveNowRequest(1, Calendar.getInstance(), "123", 2)
+        centralSystem.sendReserveNowRequest(0, Calendar.getInstance(), "123", 2)
 
         then:
         conditions.eventually {

diff --git a/ocpp-v1_6/src/main/java/eu/chargetime/ocpp/model/reservation/ReserveNowRequest.java b/ocpp-v1_6/src/main/java/eu/chargetime/ocpp/model/reservation/ReserveNowRequest.java
@@ -61,7 +61,7 @@ public ReserveNowRequest(Integer connectorId, Calendar expiryDate, String idTag,
 
     @Override
     public boolean validate() {
-        boolean valid = connectorId != null && connectorId > 0;
+        boolean valid = connectorId != null && connectorId >= 0;
         valid &= expiryDate != null;
         valid &= ModelUtil.validate(idTag, 20);
         valid &= reservationId != null;
@@ -87,7 +87,7 @@ public Integer getConnectorId() {
      */
     @XmlElement
     public void setConnectorId(Integer connectorId) throws PropertyConstraintException {
-        if (connectorId <= 0)
+        if (connectorId < 0)
             throw new PropertyConstraintException("connectorId", connectorId);
 
         this.connectorId = connectorId;

diff --git a/...est/java/eu/chargetime/ocpp/feature/profile/test/ClientFirmwareManagementProfileTest.java b/...est/java/eu/chargetime/ocpp/feature/profile/test/ClientFirmwareManagementProfileTest.java
@@ -59,14 +59,38 @@ public void setup() {
     }
 
     @Test
-    public void getFeatureList_containsAllNeededFeatures() {
+    public void getFeatureList_containsGetDiagnosticsFeature() {
         // When
         Feature[] features = profile.getFeatureList();
 
         // Then
         assertThat(findFeature(features, "GetDiagnostics"), is(instanceOf(GetDiagnosticsFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsDiagnosticsStatusNotificationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "DiagnosticsStatusNotification"), is(instanceOf(DiagnosticsStatusNotificationFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsFirmwareStatusNotificationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "FirmwareStatusNotification"), is(instanceOf(FirmwareStatusNotificationFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsUpdateFirmwareFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "UpdateFirmware"), is(instanceOf(UpdateFirmwareFeature.class)));
     }
 

diff --git a/...6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ClientReservationProfileTest.java b/...6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ClientReservationProfileTest.java
@@ -61,12 +61,20 @@ public void setup() {
     }
 
     @Test
-    public void getFeatureList_containsAllNeededFeatures() {
+    public void getFeatureList_containsReserveNowFeature() {
         // When
         Feature[] features = profile.getFeatureList();
 
         // Then
         assertThat(findFeature(features, "ReserveNow"), is(instanceOf(ReserveNowFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsCancelReservationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "CancelReservation"), is(instanceOf(CancelReservationFeature.class)));
     }
 

diff --git a/...est/java/eu/chargetime/ocpp/feature/profile/test/ServerFirmwareManagementProfileTest.java b/...est/java/eu/chargetime/ocpp/feature/profile/test/ServerFirmwareManagementProfileTest.java
@@ -48,15 +48,40 @@ public void setup() {
     }
 
     @Test
-    public void getFeatureList_containsAllNeededFeatures() {
+    public void getFeatureList_containsGetDiagnosticsFeature() {
         // When
         Feature[] features = profile.getFeatureList();
 
         // Then
         assertThat(findFeature(features, "GetDiagnostics"), Is.is(instanceOf(GetDiagnosticsFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsDiagnosticsStatusNotificationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "DiagnosticsStatusNotification"), Is.is(instanceOf(DiagnosticsStatusNotificationFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsFirmwareStatusNotificationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "FirmwareStatusNotification"), Is.is(instanceOf(FirmwareStatusNotificationFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsUpdateFirmwareFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "UpdateFirmware"), Is.is(instanceOf(UpdateFirmwareFeature.class)));
     }
 
+
 }
diff --git a/...src/test/java/eu/chargetime/ocpp/feature/profile/test/ServerLocalAuthListProfileTest.java b/...src/test/java/eu/chargetime/ocpp/feature/profile/test/ServerLocalAuthListProfileTest.java
@@ -50,12 +50,21 @@ public void setup() {
     }
 
     @Test
-    public void getFeatureList_containsAllNeededFeatures() {
+    public void getFeatureList_containsGetLocalListVersionFeature() {
         // When
         Feature[] featureList = profile.getFeatureList();
 
         // Then
         assertThat(findFeature(featureList, "GetLocalListVersion"), CoreMatchers.is(instanceOf(GetLocalListVersionFeature.class)));
+    }
+
+
+    @Test
+    public void getFeatureList_containsSendLocalListFeature() {
+        // When
+        Feature[] featureList = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(featureList, "SendLocalList"), CoreMatchers.is(instanceOf(SendLocalListFeature.class)));
     }
 

diff --git a/...6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ServerReservationProfileTest.java b/...6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ServerReservationProfileTest.java
@@ -49,12 +49,20 @@ public void setup() {
     }
 
     @Test
-    public void getFeatureList_containsAllNeededFeatures() {
+    public void getFeatureList_containsReserveNowFeature() {
         // When
         Feature[] features = profile.getFeatureList();
 
         // Then
         assertThat(findFeature(features, "ReserveNow"), Is.is(instanceOf(ReserveNowFeature.class)));
+    }
+
+    @Test
+    public void getFeatureList_containsCancelReservationFeature() {
+        // When
+        Feature[] features = profile.getFeatureList();
+
+        // Then
         assertThat(findFeature(features, "CancelReservation"), is(instanceOf(CancelReservationFeature.class)));
     }
 

diff --git a/ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/reservation/test/ReserveNowRequestTest.java b/ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/reservation/test/ReserveNowRequestTest.java
@@ -57,7 +57,7 @@ public void validate_statusIsNotSet_returnsFalse() {
     @Test
     public void validate_requiredFieldsAreSet_returnTrue() throws PropertyConstraintException {
         // Given
-        Integer connectorId = 1;
+        Integer connectorId = 0;
         Calendar expiryDate = Calendar.getInstance();
         String idTag = "row";
         Integer reservationId = 2;