Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Java-WebSocket from 1.3.8 to 1.5.0 in /ocpp-v1_6 #119

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 8, 2020

Bumps Java-WebSocket from 1.3.8 to 1.5.0.

Release notes

Sourced from Java-WebSocket's releases.

Release 1.5.0

Breaking Changes

This release requires API Level 1.7.

Security

This release contains a security fix for CVE-2020-11050.

Take a look at the advisory here for more information.

Notable changes:

  • Issue 574 - Implementation of per message deflate extension (PR 866)
  • Issue 997 - Access to SSLParameters used by the WebSocketClient (PR 1000)
  • PR 1001 - Allow user to specify max number of pending connections to a server

Check out the changelog and the milestone for more information.

A special thanks to all the contributors of this release: @haruntuncay @PhilipRoman

Release 1.4.1

Notable changes:

  • PR 906 - Implemented a custom DNS resolver, see #859
  • PR 893 - Provide a way to access the SSLSession of a websocket instance
  • PR 944 - Add ability to customize ping messages with custom data
  • PR 868 - Add a way to put additional headers to handshake for connecting/reconnecting, see #865
  • PR 971 - Enabled OSGi metadata in MANIFST-MF for created JAR

Check out the changelog and the milestone for more information.

A special thanks to all the contributors of this release:

Release 1.4.0

Breaking changes:

  • Issue 753 - Breaking changes in 1.4
  • Issue 670 - Use a logging framework such as as SLF4J instead of System.out.println (PR 754)
... (truncated)
Changelog

Sourced from Java-WebSocket's changelog.

Version Release 1.5.0 (2020/05/06)

Breaking Changes

This release requires API Level 1.7.

Security

This release contains a security fix for CVE-2020-11050.

Take a look at the advisory here for more information.

New Features

  • Issue 574 - Implementation of per message deflate extension (PR 866)
  • PR 866 - Add PerMessageDeflate Extension support, see #574
  • Issue 997 - Access to SSLParameters used by the WebSocketClient (PR 1000)
  • Issue 574 - Implementation of per message deflate extension (PR 866)
  • PR 1001 - Allow user to specify max number of pending connections to a server
  • PR 1000 - SSLParameters for WebSocketClient
  • PR 866 - Add PerMessageDeflate Extension support, see #574

In this release 3 issues and 4 pull requests were closed.

###############################################################################

Version Release 1.4.1 (2020/03/12)

Bugs Fixed

  • Issue 940 - WebSocket handshake fails over WSS, if client uses TLS False Start (PR 943)
  • Issue 921 - ConcurrentModificationException when looping connections
  • Issue 905 - IOException wrapped in InternalError not handled properly (PR 901)
  • Issue 900 - OnClose is not called when client disconnect (PR 914)
  • Issue 869 - Lost connection detection is sensitive to changes in system time (PR 878)
  • Issue 665 - Data read with end of SSL handshake is discarded (PR 943)
  • PR 943 - Merge pull request #943 from da-als/master
  • PR 922 - Fix ConcurrentModificationException when iterating through connection
  • PR 914 - Merge pull request #914 from marci4/Issue900
  • PR 902 - ConcurrentModificationException when using broadcast
  • PR 901 - fix when proxy tunneling failed (IOException is hidden) JDK-8173
  • PR 878 - Replace TimerTask with ScheduledExecutorService

New Features

  • Issue 969 - Loggers should be declared non-static (PR 970)
  • Issue 962 - Improvements in socket connect to server (PR 964)
  • Issue 941 - How to send customized ping message on connectionLostTimeout interval (PR 944)
  • Issue 890 - Would like to get SSLSession from WebSocket on server to examine client certificates (PR 893)
  • Issue 865 - Append new headers to the client when reconnecting
... (truncated)
Commits
  • 54ca4f4 Merge pull request #1009 from marci4/UpdateChangelog1.5.0
  • 046f24b Update CHANGELOG.md
  • 63222d1 Merge pull request #1006 from marci4/FixTestPerMessageDeflate
  • 1e2e890 Update PerMessageDeflateExtensionTest.java
  • 9d890db Merge pull request #1001 from TooTallNate/issue-991
  • cab3fda Merge pull request #1000 from marci4/Issue997
  • ca38a4b Add "since 1.5.0" tag to new methods
  • 3ebbe21 Allow user to specify max number of pending connections to a server
  • 0670985 Rework after review
  • 2dbe2d3 API for SSLParameters
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 8, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.154% when pulling aec4913 on dependabot/maven/ocpp-v1_6/org.java-websocket-Java-WebSocket-1.5.0 into 0a55207 on master.

@codecov-io
Copy link

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage     42.81%   42.81%           
  Complexity      923      923           
=========================================
  Files           220      220           
  Lines          4356     4356           
  Branches        435      435           
=========================================
  Hits           1865     1865           
  Misses         2377     2377           
  Partials        114      114           

@TVolden TVolden merged commit e7f628f into master May 9, 2020
@dependabot dependabot bot deleted the dependabot/maven/ocpp-v1_6/org.java-websocket-Java-WebSocket-1.5.0 branch May 9, 2020 14:54
@robert-s-ubi
Copy link
Contributor

That change missed the dependencies in the 3 build.gradle files, which still point to WebSockets version 1.3.8.

Also, WebSockets 1.5.0 has already been superseded by 1.5.1, which contains an Android fix.

While at it, would it be possible to change the SOAP library dependency from 1.4.0 to 1.3.8? Version 1.4.0 also has an issue with the Android 8 compiler, while 1.3.8 works. BTW, that SOAP library has been discontinued and development continued in another project (with another classpath).

@TVolden
Copy link
Member

TVolden commented May 18, 2020

Hi @robert-s-ubi,

Thanks for the help. Sure you can change the SOAP version.

Well SOAP is no longer supported in 2.0, so I guess it's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants