Bump Java-WebSocket consistently to 1.5.1 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last update of the Java-WebSocket dependency to 1.5.0 changed only the maven pom files and missed the gradle build files, which remained at 1.3.8. This change updates the dependency to 1.5.1 in all places, also picking up the Java-WebSocket 1.5.1 fix for Android.
The commit which added support for HTTP basic authentication was unfortunately missing a space character and had one newline too many, violating Google Java formatting (and making the gradle build fail). This commit fixes the violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last update of the Java-WebSocket dependency to 1.5.0 changed only
the maven pom files and missed the gradle build files, which remained
at 1.3.8.
This change updates the dependency to 1.5.1 in all places, also picking
up the Java-WebSocket 1.5.1 fix for Android.