Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client authentication on server side via callback #163

Merged
merged 6 commits into from
Nov 4, 2021
Merged

Client authentication on server side via callback #163

merged 6 commits into from
Nov 4, 2021

Conversation

dimaa6
Copy link

@dimaa6 dimaa6 commented Nov 3, 2021

No description provided.

@dimaa6
Copy link
Author

dimaa6 commented Nov 3, 2021

Contributes to #90

@dimaa6 dimaa6 mentioned this pull request Nov 3, 2021
Closed
TVolden
TVolden approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

OCPP-J/src/main/java/eu/chargetime/ocpp/WebSocketListener.java Outdated Show resolved Hide resolved
@dimaa6 dimaa6 requested a review from TVolden November 4, 2021 05:44
@dimaa6
Copy link
Author

dimaa6 commented Nov 4, 2021

I believe I addressed all the comments, please review and merge if everything is OK.

@TVolden TVolden merged commit ae45361 into ChargeTimeEU:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-s-ubi robert-s-ubi robert-s-ubi left review comments

@TVolden TVolden Awaiting requested review from TVolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimaa6 @TVolden @robert-s-ubi @dmitryb-asg