New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset failed flag before sending retry messages #167

Merged

TVolden merged 1 commit into ChargeTimeEU:master from listestalo:bugfix/fix_possible_endless_loop

Nov 24, 2021

listestalo commented Nov 24, 2021 •

edited

Loading

TL;DR: the error flag in Communicator never gets set back to false after it has been to to true

We've encountered some rare cases where...

the charge-point has been offline
the central-system responded with some kind of error
now the client tries to resend non-send-messages via RetryRunner but will never "pop the message" (see code) so it will send the same message again and again


          reset failed flag before sending retry messages

519c576

TVolden approved these changes

View reviewed changes

Member

TVolden commented Nov 24, 2021

Hi @listestalo,

Thanks for your contributions. I'll try to review and merge them today.

TVolden merged commit 6d88425 into ChargeTimeEU:master

robert-s-ubi mentioned this pull request

Pull request #176 broke the FirmwareManagementProfile! #183

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet