Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/fix profile initialization (nulls and cross-over in FirmwareManagementProfiles) #176

Merged

Conversation

in-fke
Copy link
Contributor

@in-fke in-fke commented Jan 27, 2022

Changes include

  1. formatting based on "./gradlew goJF"
  2. occp 1.6 - in the package eu.chargetime.ocpp.feature.profile make sure every ProfileFeature gets "Profile" passed in every CTOR
  3. remove cross-over of features in ClientFirmwareManagementProfile and ServerFirmwareManagementProfile, otherwise eu.chargetime.ocpp.Server.open(...).new ListenerEvents() {...}.newSession(...).new SessionEvents() {...}.handleRequest(Request) would fetch the wrong Profile not processing the requests correctly

Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TVolden TVolden merged commit 77d6978 into ChargeTimeEU:master Feb 26, 2022
@TVolden
Copy link
Member

TVolden commented Feb 26, 2022

There were some failing using tests as a result of the change. I removed them, since they tested for the features which was (rightly) removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants