Add transactionId to validation method of StartTransactionConfirmation

[simonweiser]

According to the OCPP 1.6 Standard the transactionId is a required field in the StartTransactionConfirmation. Some charging stations can not handle a missing transactionId. Therefore I added it to the validate() method and added some unit tests.

[coveralls]

Coverage decreased (-0.03%) to 43.176% when pulling 588d6aa on simonweiser:master into 0f3e760 on ChargeTimeEU:master.

[TVolden]

Looks good.

[TVolden]

Hi @simonweiser

Thanks for you pull request. It's a big help, that people like you go through the code and correct stuff like this. I really appreciate it.

The integration tests fails, probably because the request/responses aren't set up to pass the new validation rule. Can I get you to look into it?

[codecov-io]

Codecov Report

Merging #91 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #91      +/-   ##
============================================
- Coverage     41.93%   41.87%   -0.06%     
+ Complexity      877      876       -1     
============================================
  Files           214      214              
  Lines          4226     4227       +1     
  Branches        437      438       +1     
============================================
- Hits           1772     1770       -2     
- Misses         2349     2351       +2     
- Partials        105      106       +1

[simonweiser]

Hi @TVolden

I fixed the integration tests and aligned it to the new validation rule.

[TVolden]

Thanks Simon, I have merged it in.