Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I have an immature small suggestion #1209

Closed
dsencheng opened this issue Jul 1, 2016 · 10 comments
Closed

I have an immature small suggestion #1209

dsencheng opened this issue Jul 1, 2016 · 10 comments
Labels
idea task

Comments

@dsencheng
Copy link

I think _autoScaleMinMaxEnabled... should be after calcModulus () in BarLineChartViewBase.drawRect(), because _leftAxis._axisMinimum will be recalculated。YAxisRenderer?.computeAxis(yMin:yMax:) no recalculation。

Rarely appeared the error Ymax text in YAxis
sorry, english is not good.
@liuxuan30 liuxuan30 added the idea label Jul 4, 2016
@danielgindi
Copy link
Collaborator

Can you test if you experience a problem like this in Charts 3.0?

@liuxuan30 liuxuan30 added the task label Aug 12, 2016
@danielgindi
Copy link
Collaborator

@PhilJay I think that autoScaleMinMaxEnabled does not work at all in 3.0

@PhilJay
Copy link
Collaborator

PhilJay commented Aug 14, 2016

I am afraid that was missed.
It was related to the way the calcMinMax() method used to work, am I right? Where it allowed to provide a minimum and maximum "x-position" to calculate the min and max values.

@danielgindi
Copy link
Collaborator

Yeah... We need to find a way to allow recalculating min/max as the viewport moves, according to the lowest/highest visible x

@PhilJay
Copy link
Collaborator

PhilJay commented Aug 14, 2016

Maybe we can provide an additional calcMinMax(float minX, float maxX) method for the ChartData class?

@danielgindi
Copy link
Collaborator

Or maybe make the calcMinMax test for autoScaleMinMaxEnabled?

@PhilJay
Copy link
Collaborator

PhilJay commented Aug 14, 2016

So you would move the autoScaleMinMaxEnabled flag to the ChartData class? Or how would you do the "testing"?

@danielgindi
Copy link
Collaborator

Oh yeah that's problematic lol

So change the signature to calcMinMax(float minX, float maxX) like you suggested, and add an overload on BarLineChartViewBase?

@PhilJay
Copy link
Collaborator

PhilJay commented Aug 14, 2016

Yes something like that. Good thing is we have methods like dataSet.getEntryForXValue(...) which allow us to find the first and last Entry to be used for calculation based on the provided minX and maxX.

@PhilJay
Copy link
Collaborator

PhilJay commented Aug 14, 2016 •
edited
Loading

Android fixes are out (2 commits):

Please review 👍

liuxuan30 added a commit that referenced this issue Sep 1, 2016
@liuxuan30
migrate Chart v3 code in master to swift 2.3 syntax (#1387)
129aab6 
migrate Chart v3 code in master to swift 2.3 syntax (#1387)

* upgrade carthage to 0.17.1

* use master commit for iso-snapshot-test-case for now. once the fix is tagged we could change to the new version

* change Rakefile, comment out tvOS because no FBSnapshotTestCase

* Add missing imports for iOS 7 support

* Update ChartSelectionDetail.swift

* BUGFIX: fix infinite recursive call of getXIndex(_:)

* for #1208, seems drawBarShadowEnabled should be false by default

* 1. update ios-snapshot-test-case to 2.1.2
2. remove brew upgrade carthage, because travis saying

* improve descriptions to warn users how to use setVisibleRange APIs

* Typo fix

* upgrade Realm to 1.0.2

* update Realm pod spec to 1.0.2

* fix pod spec typo

* Work on x-values instead of x-indices (free for all :-)

* Improvement for pie slice spacing calculation

* Example improvements

* Docs improvements

* Major work on highlights

* ChartMarker is now a protocol, and we have ChartMarkerView/Image helpers

* Improvements regarding irrelevant inherited methods

* Added feature to change color of "no data" text

* More work on highlights

* Viewport enhancements for better horizontal bar support

* X-axis renderer enhancements for better horizontal bar support

* Minor improvement to valueFormatter

* Completed copy routine for scatter dataset

* Pie: Renamed `drawSliceTextEnabled` to `drawEntryLabelsEnabled`

* Pie: Added feature to offset center text

* Pie: Separate color/font for entry labels (defaults to value color/font)

* Minor improvements to demo

* Minor refactoring of variable names

* Example cleanup

* Refactored scatter shape rendering into interface and renderers

* Improved docs

* Removed deprecated --var / var--

* Update README.md

* Dropped iOS 7.0 support from README (Closes #601)

* Fixed a RadarChart bug where value labels were misplaced

* Realm fixes

* Improvements to zoom methods

* Legend improvements

* DRYed some code

* Adjusted maxHighlightDistance defaults

* Removed NaN check for highlight.

* Cleanup these comments

* `drawBarShadowEnabled` is working again

* Do not invalidate here by default, like other zoom methods

* Simplified scatter shape enum model

* These return a single pixel (x/y), for values (x value and y value)

* Renamed x-pos to x-value where appropriate

* Renamed ChartMarker -> IChartMarker

* Namespace `Marker` names only for Objc (Swift 2.2)

The Charts v3 changes are a chance to do this,
  as it's a breaking change anyway.

* Do not force unwrap here

* Fix for comments

* More improvements to Markers, default behaviour constraint to view size

* Docs

* The highlight breaking changes are a chance to use @objc(name) feature

* Use @objc(name) feature for rarely used classes (by users)

* Improved entryIndex rounding method

* Fixed drawing bounds for some of the charts

* Removed unused yValueForXValue / yValuesForXValue

* Set a default shape renderer

* Take the correct barData object here

* Fixed combined chart highlight with bar data

* Minor refactoring

* Removed the extra offset that messed up legend location

* Cache XBounds object

* Breaking change: `valueFormatter` now accepts an IValueFormatter

This allows for formatting depending on viewport state etc.

* Avoid x values in Pie's calcMinMax

* This workaround is not required in the newer compilers

* Renamed formatter interfaces

FillFormatter -> IFillFormatter
ValueFormatter -> IValueFormatter
AxisValueFormatter -> IAxisValueFormatter

* Avoid truncating using Int(...), it overflows

* Corrected formula for 29-feb :-)

* Some minor bug fixes for formatters

* Polished demos

* More improvements to examples

* These should be internal

* Fixed xAxis min/max calculation typo

* Added helper to generate a fill formatter with a closure (block)

* Added more samples

* Updated tests

* Set default barWidth to match old default behaviour

* Renamed axisMinValue/axisMaxValue to axisMinimum/axisMaximum

* Cleaned up header comments

(I know that most of these files were created by me, I don't need that
 in the headers...)

* Removed deprecated startAtZero properties

* When only one of scaleXEnabled or scaleYEnabled is effective

* Docs

* Cleanup

* Use EPSILON instead of an arbitrary value (Fixes #1239)

* Fix dataset update in Dual line chart demo (Fixes #1250)

* Add half line width to clipping rect of grid/limit lines (Fixes #1204)

* Simplified legend entries configuration. Option to style dataset form.

(Closes #1282)

* Added feature for dashing legend line forms

* Change default formLineWidth to match the default on MPAndroidChart

* neededWidth should be enough here. formSize has no meaning globally.

If more offset is needed - use extraOffsets, or adjust the maxSizePercent).

* Renamed those classes too. Cleaner now. Should be too breaking...

As with swift's minimal syntax - the chance of anyone referencing
  those by name is very low.
On ObjC, the names stayed the same, for namespacing.

* Take care of edge cases when calculating intervals (labelCount == 0)

* autoScaleMinMax is working again (Fixes #1209)

* Minor refactoring (Closes #1187)

Sorry, un-mergable to `master`...

* Fixed reversed condition from cbd7bf7

* It's clearer this way

* Fill before stroke - because the fill may cover half of a thick stroke

(Closes #982)

* Added those new classes to tvOS/macOS targets

* Migrated viewFromXib to macOS

* Call `print` under `Swift` namespace, due to Cocoa ambiguity in NSView

* Migrated macOS demos to Charts 3.0

* Use an optional for _displayLink (Fixes #1336)

_displayLink might not have been created, i.e. in Interface Builder context.

* Corrected LineChartRenderer cubicFill x range

* Fixed horizontal cubic calculation bug introduced when removing x-index

* Avoid using deprecated property in demo

* Updated test screenshots

* Animating the wrong axis for the starting point

* migrate Chart v3 code in master to swift 2.3 syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danielgindi @dsencheng @liuxuan30 @PhilJay