color in BalloonMarker is never used

[liuxuan30]

got a warning saying if let color = color is never used in BalloonMarker.
I take a look at it and found color is never used as well.
I'm not sure why we have if let color = color and did nothing. Any idea what's the color is supposed to do? @danielgindi @jjatie

[thierryH91200]

it's the background color
it was a long time

    if let color = color
    {
        context.setFillColor(color.cgColor)
        context.beginPath()
        context.move(to: CGPoint(
            x: rect.origin.x,
            y: rect.origin.y))
        context.addLine(to: CGPoint(
            x: rect.origin.x + rect.size.width,
            y: rect.origin.y))
        context.addLine(to: CGPoint(
            x: rect.origin.x + rect.size.width,
            y: rect.origin.y + rect.size.height - arrowSize.height))
        context.addLine(to: CGPoint(
            x: rect.origin.x + (rect.size.width + arrowSize.width) / 2.0,
            y: rect.origin.y + rect.size.height - arrowSize.height))
        context.addLine(to: CGPoint(
            x: rect.origin.x + rect.size.width / 2.0,
            y: rect.origin.y + rect.size.height))
        context.addLine(to: CGPoint(
            x: rect.origin.x + (rect.size.width - arrowSize.width) / 2.0,
            y: rect.origin.y + rect.size.height - arrowSize.height))
        context.addLine(to: CGPoint(
            x: rect.origin.x,
            y: rect.origin.y + rect.size.height - arrowSize.height))
        context.addLine(to: CGPoint(
            x: rect.origin.x,
            y: rect.origin.y))
        context.fillPath()
    }

[liuxuan30]

hi @thierryH91200 thanks, may I ask where did you get context.setFillColor(color.cgColor), you write it yourself, or it used to exist in the library, and removed by mistake?

[thierryH91200]

https://github.com/danielgindi/Charts/blob/master/ChartsDemo/Swift/Components/BalloonMarker.swift

I do not know if we're talking about the same thing

[liuxuan30]

@thierryH91200 you are refering swift demo's. seems we have a big diff between Objc demo's balloon marker and Swift demo's.
Seems we should port the swift one into objc demo.