Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animated update for barchart #2889

Closed
wants to merge 10 commits into from
Closed

Conversation

kevinjtchen
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2889 into master will decrease coverage by 0.02%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2889      +/-   ##
==========================================
- Coverage   19.64%   19.61%   -0.03%     
==========================================
  Files         113      113              
  Lines       13792    13829      +37     
==========================================
+ Hits         2709     2713       +4     
- Misses      11083    11116      +33
Impacted Files Coverage Δ
Source/Charts/Animation/Animator.swift 1.09% <0%> (-0.2%) ⬇️
Source/Charts/Charts/ChartViewBase.swift 24.13% <0%> (-0.11%) ⬇️
Source/Charts/Renderers/BarChartRenderer.swift 41.97% <61.53%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8245f32...d738fc1. Read the comment docs.

@robgravy robgravy mentioned this pull request Oct 17, 2017
@kevinjtchen
Copy link
Author

no longer needed

@kditraglia
Copy link

Why is this no longer needed, is there another work-around that can get the effect you added here?

@cowgp
Copy link

cowgp commented Nov 22, 2017

Why is this not needed? am I missing some other PR that has this functionality that did get merged? I would really like to see this exact feature as build in this PR

@av0c0der
Copy link

@kevinjtchen can you please answer the questions above. I was looking for this functionality and came here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants