-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utils Cleanup #3054
Merged
Merged
Utils Cleanup #3054
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0cb56dd
Cleanup
jjatie 35c7a6c
Merge branch 'master' into utils-cleanup
jjatie d732523
Merge branch 'master' into utils-cleanup
jjatie 726814b
Merge remote-tracking branch 'upstream/master' into utils-cleanup
jjatie 8c1f8c9
Pulled latest master
jjatie e3ad45f
Merge remote-tracking branch 'origin/utils-cleanup' into utils-cleanup
jjatie 52c4978
Pulled latest master
jjatie 5193596
Merge remote-tracking branch 'upstream/master' into utils-cleanup
jjatie 8af6110
Pulled latest master
jjatie dbbadd3
Fix after pulling master
jjatie 88f1811
Fixed using wrong axis (Issue #2257)
defranke 7238ba9
fix #1830. credit from https://github.com/danielgindi/Charts/pull/204…
liuxuan30 64bc2d1
Merge pull request #3114 from defranke/HorizontalBarChart-Axis
liuxuan30 c8ae3ea
Removed redundant ivars in BarLineChartViewBase (#3043)
jjatie bbeb88d
Update 4.0.0 with master (#3135)
jjatie 1658a63
Replaced relevant `ChartUtils` methods with `Double` extensions (#2994)
jjatie 48ac6a6
add option to build demo projects unit tests on iOS (#3121)
liuxuan30 faf7ed5
Merge branch 'master' of https://github.com/danielgindi/Charts into u…
jjatie 9706fa1
Update ViewPortHandler.swift (#3143)
ParkinWu 0ced631
Refactored ChartUtils method into CGPoint extension (#3087)
jjatie 32772e0
Finished cleanup
jjatie 19f52d9
Merge remote-tracking branch 'upstream/master' into utils-cleanup
jjatie 85fb250
Pulled master
jjatie e4b177b
Synced with 4.0.0
jjatie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a chained call? how about putting in on line. seems a little distractive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fairly standard Swift practice.