Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the error title for demo #3528

Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix the error title for demo #3528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/HalfPieChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Half Pie Bar Chart";
self.title = @"Half Pie Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Y-Values"},
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/PieChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Pie Bar Chart";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petester42 @jjatie need some advise on the name. Pie Bar Chart is ok or kind of typo ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO
"Pie Chart" is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree. It's more clear.

self.title = @"Pie Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Y-Values"},
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/PiePolylineChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Pie Bar Chart";
self.title = @"Pie Poly Line Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Y-Values"},
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/PositiveNegativeBarChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Bar Chart";
self.title = @"Positive/Negative Bar Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Values"},
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/RadarChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ - (void)viewDidLoad

self.activities = @[ @"Burger", @"Steak", @"Salad", @"Pasta", @"Pizza" ];

self.title = @"Radar Bar Chart";
self.title = @"Radar Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Values"},
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Objective-C/Demos/ScatterChartViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Scatter Bar Chart";
self.title = @"Scatter Chart";

self.options = @[
@{@"key": @"toggleValues", @"label": @"Toggle Values"},
Expand Down
2 changes: 2 additions & 0 deletions ChartsDemo-iOS/Swift/Demos/AnotherBarChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class AnotherBarChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Another Bar Chart"

self.options = [.toggleValues,
.toggleHighlight,
.animateX,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/CandleStickChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CandleStickChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Bubble Chart"
self.title = "Candle Stick Chart"
self.options = [.toggleValues,
.toggleIcons,
.toggleHighlight,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/HalfPieChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class HalfPieChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Half Pie Bar Chart"
self.title = "Half Pie Chart"

self.options = [.toggleValues,
.toggleXValues,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/LineChartTimeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class LineChartTimeViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Line Chart 2"
self.title = "Time Line Chart"
self.options = [.toggleValues,
.toggleFilled,
.toggleCircles,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/PieChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class PieChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Half Pie Bar Chart"
self.title = "Pie Chart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the 'half' word?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the "Pie Chart" is correct since the controller name is "PieChartViewController".
BTW, I have fixed the title to "Half Pie Chart" from "Half Pie Bar Chart" for "HalfPieChartViewController.swift"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.


self.options = [.toggleValues,
.toggleXValues,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/PiePolylineChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class PiePolylineChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Pie Bar Chart"
self.title = "Pie Poly Line Chart"

self.options = [.toggleValues,
.toggleXValues,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/PositiveNegativeBarChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class PositiveNegativeBarChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Bar Chart"
self.title = "Positive/Negative Bar Chart"
self.options = [.toggleValues,
.toggleHighlight,
.animateX,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/RadarChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class RadarChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Radar Bar Chart"
self.title = "Radar Chart"
self.options = [.toggleValues,
.toggleHighlight,
.toggleHighlightCircle,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/ScatterChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ScatterChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Scatter Bar Chart"
self.title = "Scatter Chart"
self.options = [.toggleValues,
.toggleHighlight,
.animateX,
Expand Down
2 changes: 1 addition & 1 deletion ChartsDemo-iOS/Swift/Demos/SinusBarChartViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SinusBarChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Line Chart 2"
self.title = "Sinus Bar Chart"
self.options = [.toggleValues,
.toggleHighlight,
.animateX,
Expand Down