webModlus is 1 by default, and it causes skipWebLineCount to be 0 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cause dead loop in drawWeb:
let modulus = _chart.skipWebLineCount
for var i = 0, xValCount = _chart.data!.xValCount; i < xValCount; i += modulus
{
...
}
I supposed the minimum should be 1.
liuxuan30
force-pushed
the
webModulus
branch
from
e9bb485
to
13d86ce
Compare
danielgindi
added a commit
that referenced
this pull request
Oct 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #424
webModlus is 1 by default, and it causes skipWebLineCount to be 0 and cause dead loop in drawWeb:
I supposed the minimum should be 1? Is it? @danielgindi