Alternative for SPM dynamic linking #4478
Conversation
We need [dynamic linking](https://github.com/apple/swift-package-manager/blob/master/Documentation/PackageDescription.md#methods-2) for this dependence.
Alternative for SPM dynamic linking
|
@alexruperez Could you elaborate on why you need dynamic linking for Charts? I am curious what the use case is. |
|
@jjatie we have Charts integrated in a dynamic framework through Swift Package Manager, when trying to integrate this framework into other dynamic frameworks and in our app, being static, it gives duplicated symbols error. |
|
Makes sense. You'll need to ensure CI is passing. |
|
The CI is failing, but not from this MR code. 😞 ==> java has been moved to Homebrew.
To uninstall the cask run:
brew cask uninstall --force java
==> Installing java...
Warning: openjdk 13.0.2+8_2 is already installed and up-to-date
To reinstall 13.0.2+8_2, run `brew reinstall openjdk`
The command "brew update" failed and exited with 1 during . |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #4478 +/- ##
=========================================
Coverage ? 41.10%
=========================================
Files ? 124
Lines ? 9423
Branches ? 0
=========================================
Hits ? 3873
Misses ? 5550
Partials ? 0 Continue to review full report at Codecov.
|
|
@jjatie @danielgindi @danicoello @liuxuan30 ready for merge! 😃 |
|
When will be available a new release (tag) with this changes? Thanks. |
|
emm, not sure if we want to release a minor version for this. We are planning a 4.0 release soon, at least like a pre release, as it's a very big change and upgrade |
Alternative for SPM dynamic linking (ChartsOrg#4478)
* Alternative for SPM dynamic linking We need [dynamic linking](https://github.com/apple/swift-package-manager/blob/master/Documentation/PackageDescription.md#methods-2) for this dependence. * Update Package.swift
* master: update changelog. Fixed incorrect guard return statement when rendering limit lines (ChartsOrg#4563) Fix bounds checks on binary search (ChartsOrg#4577) Added SPM build action (ChartsOrg#4576) Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing (ChartsOrg#4574) Import swift algorithms (ChartsOrg#4497) ChartViewBase cleanup (ChartsOrg#4537) SPM GitHub Action (ChartsOrg#4553) Algorithm updates (ChartsOrg#3638) Added SPM Install section Update README.md Fix missing drawIconsEnabled parameter initialization in the copying constructor of the ChartBaseDataSet (ChartsOrg#4424) Resolve conflict for 4.0 branch and master (ChartsOrg#4456) Alternative for SPM dynamic linking (ChartsOrg#4478) 3.6.0 changelog # Conflicts: # Source/Charts/Renderers/LineChartRenderer.swift
We need dynamic linking for this dependence.
This change is