Add double mark for compiler check related with issue #4835 #4836
Conversation
|
lgtm |
|
thank you @MichalMartinu , this pr is still open because of 1 workflow awaiting approval |
|
hey @MichalMartinu , a maintainer with write access may need to approve any workflow runs. Can you give approve to workflow run? |
|
Hi @danielgindi, @pmairoldi, can you approve this PR to provide support for Xcode14(beta)? |
|
We usually do not support betas as things can change all the time. When Xcode 14 is GM we will release something if need be. Will keep this open for now. |
|
In Xcode 14 beta 6 I dont get this error anymore. Closing |
|
Actually never mind. The library compiles fine but this is needed to run in an app. Kinda weird. |
|
Thanks for the contribution! |
@pmairoldi When can we expect a release with this fix? |
|
I will wait until the Xcode 14 gm and if everything is still fine I’ll release a new version. |
Compiler isn't able to build this library on Xcode 14. Details on original library PR: ChartsOrg#4836
Issue Link 🔗
#4835
in Xcode14 there is an compiler check error because of ambiguity of some math arithmetics, so this pr aim to fix it
Goals ⚽
Because of this compiler error, i aim to fix this problem for xcode14-beta versions
Implementation Details 🚧
There are no architectural changes, I just put Double casting into magic number as
1.0