Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double mark for compiler check related with issue #4835 #4836

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Add double mark for compiler check related with issue #4835 #4836

merged 1 commit into from
Aug 28, 2022

Conversation

eliakorkmaz
Copy link
Contributor

Issue Link 🔗

#4835

in Xcode14 there is an compiler check error because of ambiguity of some math arithmetics, so this pr aim to fix it

Goals ⚽

Because of this compiler error, i aim to fix this problem for xcode14-beta versions

Implementation Details 🚧

There are no architectural changes, I just put Double casting into magic number as 1.0

@michalnowak061
Copy link

lgtm

Copy link

@MichalMartinu MichalMartinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliakorkmaz
Copy link
Contributor Author

thank you @MichalMartinu , this pr is still open because of 1 workflow awaiting approval

@eliakorkmaz eliakorkmaz reopened this Jun 23, 2022
@eliakorkmaz
Copy link
Contributor Author

hey @MichalMartinu , a maintainer with write access may need to approve any workflow runs.

Can you give approve to workflow run?

@lchamp
Copy link

lchamp commented Jun 29, 2022

Hi @danielgindi, @pmairoldi, can you approve this PR to provide support for Xcode14(beta)?
Thanks in advance!

@pmairoldi
Copy link
Collaborator

We usually do not support betas as things can change all the time. When Xcode 14 is GM we will release something if need be. Will keep this open for now.

@pmairoldi
Copy link
Collaborator

pmairoldi commented Aug 28, 2022

In Xcode 14 beta 6 I dont get this error anymore. Closing

@pmairoldi pmairoldi closed this Aug 28, 2022
@pmairoldi
Copy link
Collaborator

Actually never mind. The library compiles fine but this is needed to run in an app. Kinda weird.

@pmairoldi pmairoldi reopened this Aug 28, 2022
@pmairoldi pmairoldi merged commit c8aa118 into ChartsOrg:master Aug 28, 2022
@pmairoldi
Copy link
Collaborator

Thanks for the contribution!

@michalnowak061
Copy link

michalnowak061 commented Aug 29, 2022

Thanks for the contribution!

@pmairoldi When can we expect a release with this fix?

@pmairoldi
Copy link
Collaborator

I will wait until the Xcode 14 gm and if everything is still fine I’ll release a new version.

mikehouse added a commit to mikehouse/Charts that referenced this pull request Sep 8, 2022
gusenico added a commit to ScaCap/Charts-1 that referenced this pull request Oct 7, 2022
Compiler isn't able to build this library on Xcode 14. Details on original library PR: ChartsOrg#4836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants