Drag offset fix (again) #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2015 15:29
Since the if statement got a bit complex, I’ve split it up into two separate if statements.
|
Please first match it with the logic on the Android part Also please fix the code styling... |
|
Ok logic seems fine, but curly brackets should always be on a new line for clarity. if _dataNotSet || !_dragEnabled ||
(self.hasNoDragOffset && self.isFullyZoomedOut && !self.isHighlightPerDragEnabled)
{
return false
} |
Sorry for the code styling (just not used to that style)…
I’ve checked the Android counterpart and though the whole gesture
functionality is quit different I found the code block that checks this
thick. The problem is that it checks the different way around…
Android code:
```java
if (mChart.hasNoDragOffset()) {
if (!mChart.isFullyZoomedOut() &&
mChart.isDragEnabled())
mTouchMode = DRAG;
else {
if (mChart.isHighlightPerDragEnabled())
performHighlightDrag(event);
}
} else if (mChart.isDragEnabled()) {
mTouchMode = DRAG;
}
```
|
The code that I've pasted here (which is actually the way you wrote it, only styled) matches the android logic, I checked. Android and iOS thinks differently about gestures, but the logics of those flags stayed the same. Please squash everything into one commit. |
|
Shall I create a new PR with all the things I've changed in one commit? |
|
Is this supposed to be fixed in v2.1.5 @danielgindi? I'm running into this issue all of a sudden and am trying to troubleshoot. |
|
No its in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the previous fix. This one should now work correctly. Sorry for that.