Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node 12 deprecation warning #5043

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix Node 12 deprecation warning #5043

merged 1 commit into from
Jun 2, 2023

Conversation

FelixHerrmann
Copy link
Contributor

@FelixHerrmann FelixHerrmann commented Apr 10, 2023

Goals ⚽

The GitHub checkout action v2 uses Node.js 12. This version of Node is deprecated and will be fully removed in summer 2023, see this blog post.
Screenshot 2023-04-10 at 15 55 30

Implementation Details 🚧

I have updated all checkout actions to us v3 instead of v2.

Testing Details πŸ”

I couldn't test it with this repo, but I have not experienced any issues with the other workflows where I have done the upgrade.

Edit: CI is not failing and the warnings are gone: https://github.com/danielgindi/Charts/actions/runs/4658235640

@pmairoldi pmairoldi added this to the 5.0.0 milestone May 6, 2023
@pmairoldi
Copy link
Collaborator

Nice catch. Thanks.

@pmairoldi pmairoldi merged commit 10ab125 into ChartsOrg:master Jun 2, 2023
@FelixHerrmann FelixHerrmann deleted the fix-node-12-deprecation-warning branch June 3, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants