Add "Toggle Data" option to demo charts. (#771 Support) #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ChartViewBase's _data property declaration from _data! to _data? to allow for setting the chart's data back to nil. Updated the code base to property handle _data as an optional value.
Added a "Toggle Data" option to each of the view controllers in the charts demo project. This option will either set the chart's data property to nil if toggled off or to the default data if toggled on.
danielgindi
added a commit
that referenced
this pull request
Feb 28, 2016
Add "Toggle Data" option to demo charts. (#771 Support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to the demo charts project view controllers to toggle the charts data to nil or default values. Used test each chart type for pull request #772 to verify that setting the data property causes the chart to properly treat the data as nil.
Note that this pull request includes changes from pr #772. pr #772 should be merged in first and then, if desired, this pr as well.