Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whispers don't respect user highlight rules #3064

Closed
Felanbird opened this issue Jul 23, 2021 · 4 comments
Closed

Whispers don't respect user highlight rules #3064

Felanbird opened this issue Jul 23, 2021 · 4 comments
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Highlights Issues related to highlights and ping sounds

Comments

@Felanbird
Copy link
Collaborator

Describe your issue

When a user you have highlighted whispers you, it will show up in your mentions despite having "show in mentions" disabled.

  1. Add a user to highlights
  2. Un-toggle "Show in Mentions"
  3. Have said user whisper you
  4. See the whisper in #/mentions
  5. 🐧

Screenshots
image

OS and Chatterino Version
windows 10 ae9f92d
@Felanbird Felanbird added the issue-report An issue reported by a user. label Jul 23, 2021
@leon-richardt
Copy link
Collaborator

leon-richardt commented Jul 23, 2021 •
edited
Loading

Could possibly be fixed in conjunction with #2731

@zneix zneix added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Jul 24, 2021
@Mm2PL
Copy link
Collaborator

Mm2PL commented Jul 24, 2021 •
edited
Loading

Can reproduce on bdf45c4 (upstream ae9f92d)

@Mm2PL Mm2PL added the Feature: Highlights Issues related to highlights and ping sounds label Aug 12, 2022
@Felanbird
Copy link
Collaborator Author

As a bandage fix for this issue, the filter !(channel.name == "/whispers") can be applied to your mentions tab, but this will filter out correctly working mentions when a highlighted phrase is triggered in a whisper.

@Felanbird
Copy link
Collaborator Author

Probably fixed by #4389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Highlights Issues related to highlights and ping sounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mm2PL @leon-richardt @Felanbird @zneix