Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop whispers from showing up in /mentions unless they match another highlight #4389

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Stop whispers from showing up in /mentions unless they match another highlight #4389

merged 4 commits into from
Feb 18, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Feb 18, 2023

  • Only highlight whispers that have the ShowInMentions flag
  • Add tests for whisper in and out of mentions
  • Add changelog entry

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

pajlada
pajlada commented Feb 18, 2023
View reviewed changes
Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada enabled auto-merge (squash) February 18, 2023 11:41
Wissididom
Wissididom reviewed Feb 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pajlada pajlada merged commit 2629e3b into master Feb 18, 2023
@pajlada pajlada deleted the fix/stop-whispers-from-showing-up-in-mentions-unless-they-contained-a-highlight-phrase branch February 18, 2023 12:02
@Felanbird Felanbird mentioned this pull request Feb 18, 2023
Closed
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wissididom Wissididom Wissididom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajlada @Wissididom