Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips for zero-width emotes are inaccessable #3615

Closed
4 tasks done
jupjohn opened this issue Mar 19, 2022 · 6 comments · Fixed by #4314
Closed
4 tasks done

Tooltips for zero-width emotes are inaccessable #3615

jupjohn opened this issue Mar 19, 2022 · 6 comments · Fixed by #4314
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Emotes Issues related to Emotes

Comments

@jupjohn
Copy link
Contributor

jupjohn commented Mar 19, 2022

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When a zero-width emote is posted along side a standard emote, only a tooltip for the standard emote is shown no matter where the mouse is hovered.

Screenshots

N/A

OS and Chatterino Version

Chatterino 7.3.4 (commit 530dcc3), applies to c2

@jupjohn jupjohn added the issue-report An issue reported by a user. label Mar 19, 2022
@jupjohn
Copy link
Contributor Author

jupjohn commented Mar 19, 2022

Pulled up from SevenTV#72, check comments there.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Mar 19, 2022

To reproduce:

  1. Post FeelsDankMan cvMask
  2. try to hover over the cvMask emote
  3. see that there is no tooltip for it, just FeelsDankMan

FeelsDankMan

@Felanbird Felanbird added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Mar 20, 2022
@jupjohn
Copy link
Contributor Author

jupjohn commented Aug 14, 2022

Been thinking about this one: what if the tooltip displayed both emotes as a "double-width" tooltip. You might have to do some fuckery to get emotes next to each other but it sounds like the nicest user experience.

@LosFarmosCTL
Copy link
Contributor

I actually really like the way chatsen displays them, only thing missing would be provider information for the emotes on the bottom, and the first FeelsDankMan is kinda unnecessary, but the general layout is pretty nice imo:

image

Not sure how feasible something like that would be to implement though, given the current LIDL zero-width emote implementation.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Aug 15, 2022 via email

@LosFarmosCTL
Copy link
Contributor

I think we would have to rework zero width emotes to actual modifier emotes

I experimented a bit with that a couple of months ago, but didn't feel like I had the knowledge about neither C++, qt or the c2 codebase to tackle this, and I don't think I would feel comfortable working on it now as well.

From what I could tell though this will require some pretty drastic changes to both emote and even general rendering, considering that not only are emotes being drawn completely separately, but animated images are even rendered in a completely separate method and canvas compared to normal UI elements (which is also the reason why they are drawn above non-animated zero-width emotes, they are actually just drawn later on top of the entire UI)

Maybe we could actually create separate emotes for combinations of emote+zerowidth, but this would create additional memory usage and would definitely still be a hacky solution, I can conceive of a bunch of possible side effects even by just thinking about it for a few seconds.

Whatever way a refactor like that could be going, its almost certainly going to take a very long time to get merged, if it ever happens. Not sure if that warrants slapping more hacky code on top of already messy things, but there might be no other way to fix current issues.

@Felanbird Felanbird added the Feature: Emotes Issues related to Emotes label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Feature: Emotes Issues related to Emotes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants