-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips for zero-width emotes are inaccessable #3615
Comments
Pulled up from SevenTV#72, check comments there. |
To reproduce:
FeelsDankMan |
Been thinking about this one: what if the tooltip displayed both emotes as a "double-width" tooltip. You might have to do some fuckery to get emotes next to each other but it sounds like the nicest user experience. |
I actually really like the way chatsen displays them, only thing missing would be provider information for the emotes on the bottom, and the first FeelsDankMan is kinda unnecessary, but the general layout is pretty nice imo: Not sure how feasible something like that would be to implement though, given the current LIDL zero-width emote implementation. |
I think we would have to rework zero width emotes to actual modifier emotes, this would probably be also mean solving that render order issue with animated emotes.
15 sie 2022 12:31:16 LosFarmosCTL ***@***.***>:
… I actually really like the way chatsen displays them, only thing missing would be provider information for the emotes on the bottom, and the first FeelsDankMan is kinda unnecessary, but the general layout is pretty nice imo:
[https://user-images.githubusercontent.com/80157503/184619859-1a2d6377-969a-48dc-bdfe-e412325e3584.jpeg][image][https://user-images.githubusercontent.com/80157503/184619859-1a2d6377-969a-48dc-bdfe-e412325e3584.jpeg]
Not sure how feasible something like that would be to implement though, given the current LIDL zero-width emote implementation.
—
Reply to this email directly, view it on GitHub[#3615 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MIQJ7F5NUBF7W2SBLSTVZIL6XANCNFSM5RESXMEA].
You are receiving this because you commented. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADkAAAA5CAYAAACMGIOFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U9tDQ+gAAAAAAAAAAAAAAAA4NQAMv0AAa3l6BAAAAAASUVORK5CYII=###24x24:true###][Obrazek śledzący][https://github.com/notifications/beacon/AF62MIX5TO2UEPD7SMA4S7LVZIL6XA5CNFSM5RESXMEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJBUWPFQ.gif]Message ID: ***@***.***>
|
I experimented a bit with that a couple of months ago, but didn't feel like I had the knowledge about neither C++, qt or the c2 codebase to tackle this, and I don't think I would feel comfortable working on it now as well. From what I could tell though this will require some pretty drastic changes to both emote and even general rendering, considering that not only are emotes being drawn completely separately, but animated images are even rendered in a completely separate method and canvas compared to normal UI elements (which is also the reason why they are drawn above non-animated zero-width emotes, they are actually just drawn later on top of the entire UI) Maybe we could actually create separate emotes for combinations of emote+zerowidth, but this would create additional memory usage and would definitely still be a hacky solution, I can conceive of a bunch of possible side effects even by just thinking about it for a few seconds. Whatever way a refactor like that could be going, its almost certainly going to take a very long time to get merged, if it ever happens. Not sure if that warrants slapping more hacky code on top of already messy things, but there might be no other way to fix current issues. |
Checklist
Describe your issue
When a zero-width emote is posted along side a standard emote, only a tooltip for the standard emote is shown no matter where the mouse is hovered.
Screenshots
N/A
OS and Chatterino Version
Chatterino 7.3.4 (commit 530dcc3), applies to c2
The text was updated successfully, but these errors were encountered: