Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wayland] Drag and Drop breaks tooltips #5432

Closed
3 of 4 tasks
fruzitent opened this issue Jun 2, 2024 · 6 comments · Fixed by #5541
Closed
3 of 4 tasks

[Wayland] Drag and Drop breaks tooltips #5432

fruzitent opened this issue Jun 2, 2024 · 6 comments · Fixed by #5541
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Linux

Comments

@fruzitent
Copy link

fruzitent commented Jun 2, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

Hyprland (broken)

$ hyprctl version
Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
2024-06-02_12-18-45.mp4

Sway (works)

$ sway --version
sway version 1.9
2024-06-02_12-20-09.mp4

Screenshots

No response

OS and Chatterino Version

Chatterino 2.5.1 (commit 9ec1022) built with Qt 6.7.1 Running on Arch Linux, kernel: 6.9.2-arch1-1

@fruzitent fruzitent added the issue-report An issue reported by a user. label Jun 2, 2024
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Linux and removed issue-report An issue reported by a user. labels Jun 2, 2024
@pajlada
Copy link
Member

pajlada commented Jun 2, 2024

On X11, the tooltip instead disappears. Some investigations I've made seems to imply the issue here is changing the parent of the tooltip, which is reparented when the Split is reparented.

If you comment out split->setParent(nullptr); in SplitContainer::releaseSplit, the bug will only show up when moving the split inbetween split containers instead, since the parent of the split stays the same.

@kornes
Copy link
Contributor

kornes commented Jun 2, 2024

windows is also affected by this bug,
detaching split for drag/drop breaks all current child windows, confirmed with: select channel, pinned usercard, search popup

@JCRouzer29
Copy link

The drag/drop appears to also break emote and username autocompletion popup menus. Once moved they cease to appear.

@JCRouzer29
Copy link

Unfortunately, the pinned usercard windows are still being lost upon drag/drop logic.

Other child windows appear to be working as intended as well as emote and username completion.

Usercard.Still.Not.Working.as.Intended.mp4

@pajlada
Copy link
Member

pajlada commented Aug 30, 2024

Unfortunately, the pinned usercard windows are still being lost upon drag/drop logic.

Other child windows appear to be working as intended as well as emote and username completion.
Usercard.Still.Not.Working.as.Intended.mp4

Could you make a new issue to track this?

@Nerixyz
Copy link
Contributor

Nerixyz commented Aug 30, 2024

Unfortunately, the pinned usercard windows are still being lost upon drag/drop logic.

Can replicate on 6.7.1 and 6.7.2 but not on 6.8.0 (beta3) which should be out in about a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Linux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants