fix: parenting logic, fixing some windows & tooltips misbehaving #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the split's parent changes, that change propagates down to the created tooltip widget. This breaks tooltips on X11 & Sway (maybe more). This change ensures that the tooltip window handle's parent is always nullptr.
|
What I need tested:
|
Code_2024-08-11_16-17-41.mp4Works on Windows. |
|
Works as expected on my mac mini (except the search popup X button randomly closed the entire app without it being a crash - it happened 3 times then never again. I think there's a fairy somewhere in my macmini that caused it to do that to make me go insane) Works as expected on X11 with i3. The only weird thing is that when I move the split, it moves up & to the left by ~1 pixel. |
|
|
pajlada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs testing on all platforms
Fixes #5432
Fixes #5521