Sort and force grouping of includes #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
chore/sort-includes
branch
from
2717b29
to
fd963ca
Compare
pajlada
force-pushed
the
chore/sort-includes
branch
from
fd963ca
to
9aaa75c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This change enforces strict include grouping using IncludeCategories
In addition to adding this to the
.clang-formatfile and applying it in thetests/srcandsrcdirectories, I also did the following small changes:ChatterSet.hpp, I changed lrucache to a <>includeIrc2.hpp, I change common/SignalVector.hpp to a "project-include"AttachedWindow.cpp,NativeMessaging.cpp,WindowsHelper.hpp,BaseWindow.cpp, andStreamerMode.cpp, I disabled clang-format for the windows-includesWindowDescriptors.hpp, I added the missingvectorinclude. It was previously not needed because the include was handled by another file that was previously included first.clang-formatminimum version has been bumped, so Ubuntu version used in thecheck-formattingjob has been bumped to 22.04 (which is the latest LTS)