perf: ignore WM_SHOWWINDOW hide event
#4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornes
commented
Nov 28, 2022
Nerixyz
reviewed
Nov 28, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
pajlada
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
handleSHOWWINDOWis triggered by Windows for show and hide events; currently every tooltip (emotes, badges, links preview, split header) will run this function on mouse enter and leave.Content of the function only cares about show event, so this PR introduce changes to minimze wasted cpu use:
msg->wParamis false, meaning it was sent for hide eventcalcButtonsSizes()(3 control buttons in custom frame title) toshown_block, so its called only once at first show event (resizing/scale change is covered elesewhere)calcButtonsSizes()when window has no such buttons (frameless_)calcButtonsSizes()outside of windows ifdeftested:
suggest no changelog