Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix red text color persisting from message overflow highlight #4204

Merged
merged 5 commits into from
Dec 3, 2022
Merged

Fix red text color persisting from message overflow highlight #4204

merged 5 commits into from
Dec 3, 2022

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Nov 30, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

PR fixes problems with message overflow highlight, feature added in #3418

current issues:

  • selecting all (ctrl+a) on overflowed input and typing, will keep red color
  • pressing up arrow on overflowed input, will keep red color on history messages
  • removing characters at <500 position wont move red overflow marking, which can be useful when trying to edit message to fit
  • hidden recursion in setCharFormat() re-emiting QTextEdit::textChanged()

PR introduced changes to fix above:

  • always mark characters up to 500 with default color
  • add blocking of unwanted signals

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

clang-tidy review says "All clean, LGTM! 👍"

Felanbird
Felanbird reviewed Dec 2, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Felanbird
Felanbird approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected 👍

@kornes @Felanbird
Update CHANGELOG.md
2357aaa 
Co-authored-by: Felanbird <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada enabled auto-merge (squash) December 3, 2022 10:52
@pajlada pajlada merged commit db12693 into Chatterino:master Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

clang-tidy review says "All clean, LGTM! 👍"

@kornes kornes deleted the fix_message-limit-coloring branch December 3, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornes @pajlada @Felanbird