-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tooltips when hovering settings #4213
Merged
pajlada
merged 11 commits into
Chatterino:master
from
Felanbird:chore/more-hover-tooltips
Dec 3, 2022
Merged
Add more tooltips when hovering settings #4213
pajlada
merged 11 commits into
Chatterino:master
from
Felanbird:chore/more-hover-tooltips
Dec 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be a debate whether or not forcing a comma after `e.g.` is correct, but it looks ugly in our use-case so I'm removing it. https://warnell.uga.edu/sites/default/files/inline-files/ieVeg.pdf https://www.dailywritingtips.com/comma-after-i-e-and-e-g/ https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
pajlada
approved these changes
Dec 3, 2022
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Started working on this a month ago, forgot about it until today when I noticed another setting that could use a tooltip.