Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab direction change crash #4248

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Dec 19, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

fixes #4247
added connection to local signalHolder

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick changelog entry suggestion (changed term to what's used in the Settings window, and mentioned what would cause it to occur), thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: pajlada <[email protected]>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crash fixed 👍

@pajlada pajlada merged commit bc5a03a into Chatterino:master Dec 19, 2022
@kornes kornes deleted the fix_tab-direction-change-crash branch December 19, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when changing Tab layout
3 participants