Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitContainer refactor #4261

Merged
merged 31 commits into from
Dec 25, 2022
Merged

SplitContainer refactor #4261

merged 31 commits into from
Dec 25, 2022

Commits on Dec 24, 2022

  1. Remove unused include util/Helpers.hpp

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    ed5d27b View commit details
    Browse the repository at this point in the history

  2. SplitContainer::setTag fix parameter naming

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    7f66939 View commit details
    Browse the repository at this point in the history

  3. autofy/constify where possible

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    db0e18a View commit details
    Browse the repository at this point in the history

  4. More const auto ptr magicifying

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    67e2315 View commit details
    Browse the repository at this point in the history

  5. Make SplitNode::Type an enum class

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    5acf776 View commit details
    Browse the repository at this point in the history

  6. Move QuickSwitcherPopup includes from header to source file

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    ad1dc99 View commit details
    Browse the repository at this point in the history

  7. Remove unused DropRegion code

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    ba4060d View commit details
    Browse the repository at this point in the history

  8. use empty() instead of size() == 0

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    b6529d5 View commit details
    Browse the repository at this point in the history

  9. Add curly braces everywhere

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    797471c View commit details
    Browse the repository at this point in the history

  10. Remove useless reinterpret_cast 

    It was casting Node* to Node*
    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    02c4dab View commit details
    Browse the repository at this point in the history

  11. Clarify that the connect is QObject::connect

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    7b982da View commit details
    Browse the repository at this point in the history

  12. SplitContainer::setSelected fix parameter naming

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    14862ff View commit details
    Browse the repository at this point in the history

  13. Rename function variables to remove unneccesary underscore 

    Also move addSpacing parameter out of the layout function
    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    06880e6 View commit details
    Browse the repository at this point in the history

  14. emplace_back where possible

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    3439950 View commit details
    Browse the repository at this point in the history

  15. Name parameters

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    33fa65b View commit details
    Browse the repository at this point in the history

  16. Remove ineffective const from return type

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    160a823 View commit details
    Browse the repository at this point in the history

  17. Make node getters const

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    3b8baa9 View commit details
    Browse the repository at this point in the history

  18. Flatten Node::releaseSplit

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    3302cf7 View commit details
    Browse the repository at this point in the history

  19. Rename in-function variable to match code style

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    b0e85f7 View commit details
    Browse the repository at this point in the history

  20. [ACTUAL CODE CHANGE/MOVE] Move clamp logic to its own function

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    ae66355 View commit details
    Browse the repository at this point in the history

  21. name params

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    3984971 View commit details
    Browse the repository at this point in the history

  22. applyFromDescriptorRecursively: rename node param to baseNode

    @pajlada
    pajlada committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    facc331 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2022

  1. [ACTUAL CODE CHANGE/MOVE] Remove the many overloads for append/insert… 

    …Split

This utilizes the C++20 designed initializers aggregate initialization feature
    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    03a27a0 View commit details
    Browse the repository at this point in the history

  2. Remove unused includes

    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    e9d8ac3 View commit details
    Browse the repository at this point in the history

  3. [ACTUAL CODE CHANGE] Clean up dragging logic 

    There's no need to keep a pointer around to which split is being
dragged, it's already stored in the QDropEvent source()
    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    560fa23 View commit details
    Browse the repository at this point in the history

  4. UNRELATED .clang-tidy: Only suggest UPPER_CASE for constant global va… 

    …riables
    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    c41d1bf View commit details
    Browse the repository at this point in the history

  5. Remove unused SplitContainer::getSplitCount function

    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    de9e762 View commit details
    Browse the repository at this point in the history

  6. Use std::max in Node's clamp function

    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    b340c3c View commit details
    Browse the repository at this point in the history

  7. Remove test code

    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    1f1b0ad View commit details
    Browse the repository at this point in the history

  8. DraggedSplit.hpp: remove unused include

    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    4354cf8 View commit details
    Browse the repository at this point in the history

  9. Split setDraggingSplit into two functions, startDraggingSplit and… 

    … `stopDraggingSplit`
    @pajlada
    pajlada committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    89485a6 View commit details
    Browse the repository at this point in the history