Add Crashpad Support on Windows #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
commented
Feb 4, 2023
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ | |||
| - Dev: Added CMake Install Support on Windows. (#4300) | |||
| - Dev: Changed conan generator to [`CMakeDeps`](https://docs.conan.io/en/latest/reference/conanfile/tools/cmake/cmakedeps.html) and [`CMakeToolchain`](https://docs.conan.io/en/latest/reference/conanfile/tools/cmake/cmaketoolchain.html). See PR for migration notes. (#4335) | |||
| - Dev: Refactored 7TV EventAPI implementation. (#4342) | |||
| - Dev: Added support for building with crashpad. See PR for build instructions. (#4351) | |||
There was a problem hiding this comment.
If this stays in CI this could be changed into a minor entry.
Nerixyz
commented
Feb 4, 2023
for some reason zstd just doesn't run
pajlada
requested changes
Feb 11, 2023
pajlada
reviewed
Feb 11, 2023
pajlada
approved these changes
Feb 12, 2023
Someone (crashpad) includes Windows.h before winsock2.h
|
Regarding 88827c4 and the build failure: https://stackoverflow.com/questions/5971332/redefinition-errors-in-winsock2-h tl;dr: you have to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR adds support for building with crashpad. Currently, only Windows is supported, though support for other platforms should only require minor modifications.
The behavior is as described in #4349. The only difference now is that it's using the crashpad fork from sentry (getsentry/crashpad, modifications). It's not enabled by default - you need to enable
BUILD_WITH_CRASHPAD.Build instructions
To get meaningful minidumps, you need to have debug symbols enabled. So you need to build in
DebugorRelWithDebInfo.Here, we're building in
RelWithDebInfomode.RelWithDebInfomode:cmake --build .crashpad_handler