Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an archive link for OpenSSL 1.1.1s in BUILDING_ON_WINDOWS.md #4404

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

Sheppsu
Copy link
Contributor

@Sheppsu Sheppsu commented Feb 24, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The current link (https://slproweb.com/download/Win64OpenSSL-1_1_1s.exe) is dead and replacing it with (https://web.archive.org/web/20221101204129/https://slproweb.com/download/Win64OpenSSL-1_1_1s.exe) fixes this.

@Felanbird
Copy link
Collaborator

It's dead because slproweb only offers the currently stable version of OpenSSL, if you'd like to update it, change it to t

@Sheppsu
Copy link
Contributor Author

Sheppsu commented Feb 24, 2023

Ah I see. Would using version t instead of s affect anything though?

@Felanbird
Copy link
Collaborator

Ah I see. Would using version t instead of s affect anything though?

🤷, won't know until we try

@Felanbird
Copy link
Collaborator

I'll merge this since #4413 removed the section stating what to do if there the link is broken

Thanks 👍

@Felanbird Felanbird changed the title Fix dead link in BUILDING_ON_WINDOWS.md for OpenSSL 1.1.1s Use an archive link for OpenSSL 1.1.1s in BUILDING_ON_WINDOWS.md Mar 6, 2023
@Felanbird Felanbird enabled auto-merge (squash) March 6, 2023 19:49
@Felanbird Felanbird merged commit 01a4861 into Chatterino:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants