Add an indicator in the title bar if Streamer Mode is active #4410
Conversation
|
Button is always there on startup no matter what option, toggling to enabled or disabled and then back to |
There was a problem hiding this comment.
Light mode on Windows (so just c-v-paste light mode handling from linux/macos portion) also missing, otherwise looks good and works as expected.
Would like to explore having a slight color on the icon, red/purple or something to bring more attention to it, but I would be happy to do that in a separate PR
pajlada
changed the title
|
A small thing I noticed with a fresh install with no settings changed it only updates if you have a twitch channel added. |
|
8thony:
A small thing I noticed with a fresh install with no settings changed it only updates if you have a twitch channel added.
That's just how streamermode works, if something checks streamer mode c2 might recheck the process list. Streamer mode has a cooldown of 10 seconds between checks and caches the result.
I tried to make this PR somewhat disconnected from this behaviour so it could be changed later.
|
…re/streamer_mode_indicator
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -195,6 +195,11 @@ void SettingsDialog::filterElements(const QString &text) | |||
| } | |||
| } | |||
|
|
|||
| void SettingsDialog::setElementFilter(const QString &query) | |||
There was a problem hiding this comment.
warning: method 'setElementFilter' can be made const [readability-make-member-function-const]
| void SettingsDialog::setElementFilter(const QString &query) | |
| void SettingsDialog::setElementFilter(const QString &query) const |
src/widgets/dialogs/SettingsDialog.hpp:60:
- void setElementFilter(const QString &query);
+ void setElementFilter(const QString &query) const;
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Closes #4215.
Simply adds an icon into the Notebook bar or main window titlebar when streamer mode is enabled. Clicking said icon opens settings with
Streamer Modealready in the search bar. Icon was made into dark/light variants and rendered into png by me :)