Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.2 #4433

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Release v2.4.2 #4433

merged 5 commits into from
Mar 6, 2023

Conversation

Felanbird
Copy link
Collaborator

@Felanbird Felanbird commented Mar 5, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This release exists because after 5 years, FFZ handled the fact that their responses did not contain https: - which we had manually been adding to FFZ requests since c2e2dfb, so FFZ emotes just don't work anymore hehe.

Option 1) Merge this PR and have a quick 2.4.2 release

Option 2) Say heck the stable users and wait until later this month when #4117 has to be merged anyway (I started telling people to update tomorrow, so probably not this option)

Option 3) Do nothing and say frick FFZ (probably too late to do this one since I already merged #4432)

Checklist for making a release

  • Updated version code in src/common/Version.hpp
  • Updated version code in CMakeLists.txt
    This can only be "whole versions", so if you're releasing 2.4.0-beta you'll need to condense it to 2.4.0
  • Updated version code in resources/com.chatterino.chatterino.appdata.xml
    This cannot use dash to denote a pre-release identifier, you have to use a tilde instead.
  • Update the changelog ## Unreleased section to the new version CHANGELOG.md
    Make sure to leave the ## Unreleased line unchanged for easier merges
  • Plan my revenge against SirStendec

@Felanbird Felanbird requested review from pajlada and fourtf March 5, 2023 00:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/common/Version.hpp Show resolved Hide resolved
@fourtf fourtf merged commit c8204ef into Chatterino:master Mar 6, 2023
@Felanbird Felanbird deleted the chore/release-2.4.2 branch March 6, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants