Only log debug messages when NDEBUG is not defined #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| static constexpr QtMsgType logThreshold = QtDebugMsg; | ||
| #else | ||
| static constexpr QtMsgType logThreshold = QtWarningMsg; |
There was a problem hiding this comment.
warning: invalid case style for global constant 'logThreshold' [readability-identifier-naming]
Suggested change
| static constexpr QtMsgType logThreshold = QtWarningMsg; | |
| static constexpr QtMsgType LOG_THRESHOLD = QtWarningMsg; |
Felanbird
reviewed
Mar 10, 2023
pajlada
requested changes
Mar 15, 2023
pajlada
approved these changes
Mar 15, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from 044dd8a
Closes #4440
Pull request checklist:
CHANGELOG.mdwas updated, if applicable