Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CHATTERINO_TEST definition #4526

Merged
merged 9 commits into from
Apr 9, 2023
Merged

Remove CHATTERINO_TEST definition #4526

merged 9 commits into from
Apr 9, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 9, 2023 •
edited
Loading

Description

  • Remove Emojis.cpp CHATTERINO_TEST ifdefs
  • Remove ImageSet.cpp CHATTERINO_TEST ifdefs
  • Remove Image.cpp CHATTERINO_TEST ifdef around forceLayoutChannelViews
  • Remove Image.cpp CHATTERINO_TEST ifdefs around gif timers
  • Purposefully leak the ImageExpirationPool timer
  • Remove ImageExpirationPool CHATTERINO_TEST definition
  • Remove CHATTERINO_TEST definitions in the CMakeLists.txt files

Fixes #4524

@pajlada
Remove Emojis.cpp CHATTERINO_TEST ifdefs
cd96a9f 
This was originally required because settings were not
default-initialized before the Emojis tests were ran.

Since #4498 this is no
longer a problem.
@pajlada
Remove ImageSet.cpp CHATTERINO_TEST ifdefs
231344b 
This was originally required because settings were not
default-initialized before the Emojis tests were ran.

Since #4498 this is no
longer a problem.
@pajlada
Remove Image.cpp CHATTERINO_TEST ifdef around forceLayoutChannelViews
85a4d70 
This was not called in any of the tests anymore
@pajlada
Remove Image.cpp CHATTERINO_TEST ifdefs around gif timers
0114e58
@pajlada
Purposefully leak the ImageExpirationPool timer
6f0a1c0 
Since this is a static object, it doesn't matter if it leaks, and
leaking it makes testing more stable
@pajlada
Remove ImageExpirationPool CHATTERINO_TEST definition
94d5b2f
@pajlada
Remove CHATTERINO_TEST definitions
a195995
@pajlada
Add changelog entry
e56fef1
@pajlada
Copy link
Member Author

pajlada commented Apr 9, 2023

@Nerixyz please review

Nerixyz
Nerixyz approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@pajlada pajlada merged commit c8e1741 into master Apr 9, 2023
@pajlada pajlada deleted the chore/remove-chatterino-test-definitions branch April 9, 2023 10:18
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerixyz Nerixyz Nerixyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling chatterino When Configured With BUILD_TESTS Or BUILD_BENCHMARKS Turns on CHATTERINO_TEST
2 participants
@pajlada @Nerixyz