Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ctrl+Backspace bug after Select All in chat search popup #4536

Merged
merged 4 commits into from
May 7, 2023

Conversation

vchuynh
Copy link
Contributor

@vchuynh vchuynh commented Apr 11, 2023

Description

fixes #4461

PR fixes Ctrl+Backspace not working properly in chat search popup

  • Adds event filter to SearchPopup class. Filters for Ctrl+Backspace and clears text if entire text is selected.

@pajlada pajlada requested a review from Mm2PL April 11, 2023 18:33
@pajlada
Copy link
Member

pajlada commented Apr 11, 2023

Do you see anything potentially bad with this change @Mm2PL? I don't think we do hotkeys on inputs other than the split input one so this should be alright

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Felanbird Felanbird added this to the 2.4.4 milestone May 7, 2023
@Mm2PL Mm2PL enabled auto-merge (squash) May 7, 2023 20:46
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on 🅱️ indows

@Mm2PL Mm2PL merged commit 68f14d3 into Chatterino:master May 7, 2023
github-actions[bot]

This comment was marked as resolved.

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 7, 2023

@vchuynh,
Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.

Please create new branches (from our master) for new PRs. My suggestion would be discarding all commits from your master and replacing it with upstream:

$ git remote add upstream https://github.com/Chatterino/chatterino2
$ git fetch --all
$ git checkout master
$ git reset --hard upstream/master

For new PRs, I just use:

$ # assuming origin is your remote name (which by default it is)
$ git checkout -b <new-branch-name>
$ # ... do the changes ...
$ git push origin <new-branch-name>
$ # ... do more changes ...
$ git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+Backspace not working properly in "Search in chat's history" after Select All
4 participants