-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ctrl+Backspace bug after Select All in chat search popup #4536
Conversation
Do you see anything potentially bad with this change @Mm2PL? I don't think we do hotkeys on inputs other than the split input one so this should be alright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on
@vchuynh, If you want this, you can open a new PR where you modify the Please create new branches (from our $ git remote add upstream https://github.com/Chatterino/chatterino2
$ git fetch --all
$ git checkout master
$ git reset --hard upstream/master For new PRs, I just use: $ # assuming origin is your remote name (which by default it is)
$ git checkout -b <new-branch-name>
$ # ... do the changes ...
$ git push origin <new-branch-name>
$ # ... do more changes ...
$ git push |
Description
fixes #4461
PR fixes Ctrl+Backspace not working properly in chat search popup