Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qtimageformats Module in Qt6 CI Builds #4556

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Add qtimageformats Module in Qt6 CI Builds #4556

merged 2 commits into from
Apr 17, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Apr 17, 2023

Description

The current EXPERIMENTAL Qt6 builds (at least on Windows) are missing imageformats/qwebp.dll, which is not provided by qtbase (qtimageformats, qtbase). This PR adds qtimageformats as a required module.

Mm2PL
Mm2PL approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows users finally got to experience missing qtimageformats and not having webp work FeelsGoodMan

@pajlada pajlada merged commit cb0ab90 into Chatterino:master Apr 17, 2023
@Nerixyz Nerixyz deleted the fix/qtimageformats branch April 17, 2023 13:10
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mm2PL Mm2PL Mm2PL approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nerixyz @pajlada @Mm2PL