Remove restriction on Go To Message on system messages from search #4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
changed the title
|
Seems fine 👍 I did notice that a channel has to be "loaded" first so if you were to global search & jump-to a system-message for a channel you haven't yet interacted with, it will load the channel first and a second jump-to is required. Although after that all jump-to's in the channel work as expected. Seems like an unlikely scenario tho. |
…iction_on_goto_message_on_system_messages
|
What types of system messages are you supposed to be able to jump to with this PR? |
|
5 sie 2023 13:30:19 pajlada ***@***.***>:
What types of system messages are you supposed to be able to jump to with this PR?
—
Reply to this email directly, view it on GitHub[#4614 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AF62MIQ2ENPYRS6XUFBKGE3XTYVEFANCNFSM6AAAAAAX32Q5JQ].
You are receiving this because you authored the thread.[Obrazek śledzący][https://github.com/notifications/beacon/AF62MITKJ5OWF4IT2X2KJD3XTYVEFA5CNFSM6AAAAAAX32Q5JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTDKRZNQ.gif]Message ID: ***@***.***>
Should work on any gray system message? Disconnects, reconnects and the like might be problematic since they are spammed in every channel.
|
yep it's my bad, I forgot to rebuild the app 😎 |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…on_system_messages
…on_system_messages
pajlada
deleted the
bugfix/remove_restriction_on_goto_message_on_system_messages
branch
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
…hatterino#4614) * Remove restriction on go to message on system messages Fixes Chatterino#4608 * changelog * Change the changelog entry from a bugfix to minor --------- Co-authored-by: Rasmus Karlsson <[email protected]>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
…hatterino#4614) * Remove restriction on go to message on system messages Fixes Chatterino#4608 * changelog * Change the changelog entry from a bugfix to minor --------- Co-authored-by: Rasmus Karlsson <[email protected]>
![https://github.com/notifications/beacon/AF62MITKJ5OWF4IT2X2KJD3XTYVEFA5CNFSM6AAAAAAX32Q5JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTDKRZNQ.gif]Message](https://github.com/notifications/beacon/AF62MITKJ5OWF4IT2X2KJD3XTYVEFA5CNFSM6AAAAAAX32Q5JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTDKRZNQ.gif]Message){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4608. This has the catch that system messages will be shown in the first channel when doing Go To Message from a multichannel search. This is a little bit of a lazy fix.