Allow for customizing the behavior of Right Clicking of usernames.
#4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
changed the title
Right Clicking of usernames.
4 tasks
pajlada
requested changes
Jun 18, 2023
…re/lidl_hotkeys_for_username_right_click
pajlada
approved these changes
Jul 1, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| auto userMention = formatUserMention( | ||
| link.value, isFirstWord, commaMention); | ||
| insertText("@" + userMention + " "); | ||
| Qt::KeyboardModifier userSpecifiedModifier = |
There was a problem hiding this comment.
warning: variable 'userSpecifiedModifier' of type 'Qt::KeyboardModifier' can be declared 'const' [misc-const-correctness]
Suggested change
| Qt::KeyboardModifier userSpecifiedModifier = | |
| Qt::KeyboardModifier const userSpecifiedModifier = |
| return; | ||
| } | ||
|
|
||
| Qt::KeyboardModifiers modifiers{userSpecifiedModifier}; |
There was a problem hiding this comment.
warning: variable 'modifiers' of type 'Qt::KeyboardModifiers' (aka 'QFlagsQt::KeyboardModifier') can be declared 'const' [misc-const-correctness]
Suggested change
| Qt::KeyboardModifiers modifiers{userSpecifiedModifier}; | |
| Qt::KeyboardModifiers const modifiers{userSpecifiedModifier}; |
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow up to #4424 and #4183