Add Command to Set Logging/Filter Rules at Runtime #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
requested changes
May 16, 2023
| @@ -3211,6 +3212,8 @@ void CommandController::initialize(Settings &, Paths &paths) | |||
|
|
|||
| this->registerCommand("/shield", &commands::shieldModeOn); | |||
| this->registerCommand("/shieldoff", &commands::shieldModeOff); | |||
|
|
|||
| this->registerCommand("/c2:loggingrules", &commands::setLoggingRules); | |||
There was a problem hiding this comment.
Naming is the hardest part - I think I would prefer /c2-set-logging-rules but happy to discuss it further before merging this in
There was a problem hiding this comment.
Sounds like a good name to me.
There was a problem hiding this comment.
I'd love for us to come up with some convention for release-debug and debug-only commands. I typically use /debug- for release-debug.
Wissididom
reviewed
May 16, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
requested changes
May 17, 2023
Should've checked the docs a bit more.
pajlada
approved these changes
May 17, 2023
|
Thank you! |
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
/c2:loggingrulescommand. You invoke it like this:/c2:loggingrules chatterino.*.debug=true chatterino.http.debug=false. This will apply both rules. I'm not too sure about the command name/prefix/namespace (my thinking was to have this behind a namespace/prefix, so it's clear that this is a Chatterino command).This command is mainly for debugging release builds without restarting - so that you get more logs when you attach a debugger/console or even a dedicated program capturing logs.