-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "/shoutout" command #4638
add "/shoutout" command #4638
Conversation
I'm only able to replicate this issue when the shoutout sender is not a mod, I receive back a correct 401 when the |
i'll check on my end too and make changes, thanks!! |
Typos are fixed in e52f8bb. I've also added some error handling for the api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, some nitpicks with error handling & where the code is located
oops i forgot to return at the anon check and the argument check, i'll fix them in the evening once i get home |
Currently fixing the merge conflicts, will solve the returns in the same batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, works as expected in the few scenarios I tested it
When you've taken a look at the changes @olafyang we can go ahead and merge this in
yep looks fantastic!! please go ahead and merge it. i learned a lot from this, thanks ❤️❤️ would love to contribute some more in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Thank you! As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |
Also you'll want to do it on a branch after you clean up your master branch, as creating this PR from your master branch has made a mess for you 😁 |
Description
This pr adds a new "/shoutout" command which calls the helix api and shouts out the specified user.
Add:
/shoutout <username>
callschat/shoutouts
of helix api and gives specified user a twitch shoutout.It seems like twitch is returning a 500 for all errors excluding 429 rate limit . Trying to shoutout an user who's not a mod gives back to following in the log. Therefore I can not provide more detailed error message for now.