Add input completion test suite #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll note that this PR does not include completion tests for username nor commands. Testing these would require a fully mockable This is one of the advantages of the new system in the pending PR as strategies are testable outside of sources. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
reviewed
May 20, 2023
|
I made the mock change to make them accessible for both tests & benchmarks here #4645 |
pajlada
requested changes
May 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for
InputCompletionPopupandCompletionModelbehavior as a precursor to merging #4639. While developing these tests I identified two discrepancies in behavior from #4639 which I will fix (eventually).This PR needed to make some changes to
BttvEmotes(among others) to allow directly setting loaded emotes for mocking. It looks a bit weird but it seems necessary.Benchmarking
I've all but finished writing benchmarks for the existing input completion code. However, I can't figure out a smart way to access
tests/src/mocksfrom both tests and benchmarks. The code should obviously be shared. I tried moving it tosrcbut that would require linkinggtestintochatterino-lib(I think), which I don't understand the full implications of (nor would be I able to modify the cmake config to do so).If anyone (read: pajlada) can think of a way to share the mocks between tests and benchmarks and how to configure
CMakeLists.txt(as I also can't figure that out when simply copyingtests/src/mockstobenchmarks/src/mocks), I'd be very grateful :)