Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GenericListModel #4661

Merged
merged 9 commits into from
May 29, 2023
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented May 29, 2023

Description

  • Change GenericListModel parent type to QObject
  • GenericListModel comment typo
  • GenericListModel: Mark functions as override where possible
  • add reserve method to GenericListModel
  • GenericListModel clang-tidy: add braces
  • GenericListModel clang-tidy: Comment out unused parameter
  • GenericListModel clang-tidy: explicitly use auto *
  • GenericListModel clang-tidy: avoid repeating type
  • GenericListModel: add vector include

Initial changes taken from #4639

@pajlada pajlada merged commit e9432d3 into master May 29, 2023
@pajlada pajlada deleted the chore/input-completion-pre-pre-pre-xd branch May 29, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant