Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QObjectRef in favor of QPointer #4666

Merged
merged 6 commits into from
Jun 4, 2023
Merged

Remove QObjectRef in favor of QPointer #4666

merged 6 commits into from
Jun 4, 2023

Conversation

4rneee
Copy link
Contributor

@4rneee 4rneee commented Jun 4, 2023

Description

This PR resolves #4632

github-actions[bot]
github-actions bot reviewed Jun 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/common/NetworkPrivate.hpp Show resolved Hide resolved
src/widgets/splits/SplitInput.cpp Show resolved Hide resolved
pajlada
pajlada requested changes Jun 4, 2023
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick for clarity (thanks @Nerixyz )

src/common/NetworkPrivate.cpp Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) June 4, 2023 10:54
@pajlada pajlada merged commit 6681ed5 into Chatterino:master Jun 4, 2023
@4rneee 4rneee deleted the refactor/replace-QObjectRef-with-QPointer branch June 4, 2023 16:02
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove QObjectRef in favor of QPointer
2 participants
@4rneee @pajlada