Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to subscribe to and pin reply threads #4680

Merged
merged 8 commits into from
Jun 17, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jun 11, 2023

Description

There are two changes in this PR. First, the option to change the subscription status of a reply thread is added. Secondly, a pin-button is added, like on user cards:

example

This adds the concept of a subscribed thread. If one is subscribed to a thread, new messages will be highlighted (requires the Subscribed Reply Threads highlight option). One can subscribe to threads through the popup and by participating in a thread (requires Subscribe to participated reply threads).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/dialogs/ReplyThreadPopup.cpp Show resolved Hide resolved
@Nerixyz
Copy link
Contributor Author

Nerixyz commented Jun 11, 2023

Regarding #4678:

C:\Users\runneradmin\.cargo\bin\sccache.exe -s
  Compile requests                    474
  Compile requests executed           474
  Cache hits                           67
  Cache hits (C/C++)                   67
  Cache misses                        407
  Cache misses (C/C++)                407

I think the git output is causing the misses, since it adds different definitions every time - 67 hits are from the crashpad_handler.

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work exactly as I would expect it to, pin properly only shows up when it's related auto hide setting is enabled, same with the subscribe feature only appearing if you have thread highlights enabled. 👍

image

@pajlada pajlada changed the title Add Option to Subscribe and Pin Reply Threads Add option to subscribe to and pin reply threads Jun 17, 2023
@pajlada pajlada enabled auto-merge (squash) June 17, 2023 15:10
@pajlada pajlada merged commit aff9342 into Chatterino:master Jun 17, 2023
@Nerixyz Nerixyz deleted the feat/reply-sub-pin branch June 17, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants